Messages in this thread | | | Date | Tue, 23 Nov 2021 20:47:55 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v5 1/1] gpio: add sloppy logic analyzer using polling |
| |
On Tue, Nov 23, 2021 at 08:45:55PM +0200, Andy Shevchenko wrote: > On Tue, Nov 23, 2021 at 05:49:02PM +0100, Wolfram Sang wrote:
> > + # Check if we could parse something and the channel number fits > > > + [ "$chan" != "$elem" ] && [ "$chan" -le $max_chans ] || fail "Trigger syntax error: $elem" > > No need to execute `test` twice: > > [ "$chan" != "$elem" -a "$chan" -le $max_chans ] || fail "Trigger syntax error: $elem"
On the second thought this might be a different logic...
-- With Best Regards, Andy Shevchenko
| |