Messages in this thread | | | Subject | Re: arch/mips/mm/tlbex.c:2243:3: warning: unannotated fall-through between switch labels | From | Joe Perches <> | Date | Tue, 23 Nov 2021 09:59:58 -0800 |
| |
On Tue, 2021-11-23 at 11:56 -0600, Gustavo A. R. Silva wrote: > On Tue, Nov 23, 2021 at 09:25:17AM -0800, Joe Perches wrote: > > On Tue, 2021-11-23 at 10:50 -0600, Gustavo A. R. Silva wrote: > > > On Tue, Nov 23, 2021 at 12:52:30AM -0800, Joe Perches wrote: > > > > > > > > Perhaps this would be better: > > > > > > Feel free to send a proper patch. > > > > I commented on your proposed patch. > > And I reply giving you an option if you want to proceed. > > > And I'd prefer you actually look at and improve the code instead > > of merely silencing warnings. > > If this is a matter of preference then I should express my preferences, too. > So, I prefer to give you the opportunity of improving the code and not being > pedantic at the same time. :)
It appears to be difficult to give you suggestions on how to improve what you do.
cheers, Joe
| |