Messages in this thread | | | Date | Tue, 23 Nov 2021 18:59:23 +0200 | Subject | Re: [PATCH] virtio-blk: modify the value type of num in virtio_queue_rq() | From | Max Gurtovoy <> |
| |
On 11/17/2021 8:39 AM, cgel.zte@gmail.com wrote: > From: Ye Guojin <ye.guojin@zte.com.cn> > > This was found by coccicheck: > ./drivers/block/virtio_blk.c, 334, 14-17, WARNING Unsigned expression > compared with zero num < 0 > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn> > --- > drivers/block/virtio_blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 97bf051a50ce..eed1666eff31 100644 > --- a/drivers/block/virtio_blk.c > +++ b/drivers/block/virtio_blk.c > @@ -316,7 +316,7 @@ static blk_status_t virtio_queue_rq(struct blk_mq_hw_ctx *hctx, > struct request *req = bd->rq; > struct virtblk_req *vbr = blk_mq_rq_to_pdu(req); > unsigned long flags; > - unsigned int num; > + int num; > int qid = hctx->queue_num; > bool notify = false; > blk_status_t status;
Looks good,
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
| |