lkml.org 
[lkml]   [2021]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build failure after merge of the regulator tree
On Tue, Nov 23, 2021 at 09:26:45AM +0000, Vaittinen, Matti wrote:

> As a second thought - do we need such a stub function at all? I guess
> anyone who is actually adding a call to the
> rohm_regulator_set_voltage_sel_restricted() helper should also have the
> implementation selected. Failing to do so is probably indication of an
> error. Compile testing could perhaps be an exception but this is
> currently not supported.

> Should I just drop the stub or make it inline? Am I overlooking something?

Dropping it does seem reasonable, I can't immediately think of a case
where the stub would get used. I've queued your existing patch to try
to make sure that a fix lands tomorrow so (assuming no test issues)
please send a removal patch on top of that.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-11-23 15:19    [W:0.044 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site