lkml.org 
[lkml]   [2021]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 4/4] arm64: dts: apple: t8103: Add cd321x nodes


On Mon, Nov 22, 2021, at 23:58, Janne Grunau wrote:
> All M1 Mac devices have 2 SoC connected USB-C ports and use cd321x USB
> type C port switch and power deliver controllers. I2c bus and adresses
> configuration are for all devices equal.
> The iMac (24-inch, 2021) has a configuration with 2 additional USB-C
> ports (j456) using two addiotional cd321x controllers.
>
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> arch/arm64/boot/dts/apple/t8103-j456.dts | 18 ++++++++++++++++++
> arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 18 ++++++++++++++++++
> 2 files changed, 36 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/apple/t8103-j456.dts
> b/arch/arm64/boot/dts/apple/t8103-j456.dts
> index 7267e069355b..c6b8c28455f5 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j456.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j456.dts
> @@ -21,6 +21,24 @@ aliases {
> };
> };
>
> +&i2c0 {
> + hpm2: tps6598x@3b {

I know that the tps example in the binding uses tps6598x as the node name
but I think that these names are usually more general. Maybe usb-pd@3b
instead which is used in arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
and reflects the function of this device.

With that fixed:

Reviewed-by: Sven Peter <sven@svenpeter.dev>


Thanks,

Sven

\
 
 \ /
  Last update: 2021-11-23 12:57    [W:0.096 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site