Messages in this thread Patch in this message |  | | Date | Tue, 23 Nov 2021 11:47:19 +0000 | From | Mark Rutland <> | Subject | Re: [PATCH 2/9] arm64: Add comment for stack_info::kr_cur |
| |
On Wed, Nov 17, 2021 at 02:07:30PM +0000, Mark Rutland wrote: > We added stack_info::kr_cur in commit: > > cd9bc2c9258816dc ("arm64: Recover kretprobe modified return address in stacktrace") > > ... but didn't add anything in the corresponding comment block. > > For consistency, add a corresponding comment. > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Cc: Masami Hiramatsu <mhiramat@kernel.org> > Cc: Steven Rostedt (VMware) <rostedt@goodmis.org> > Cc: Will Deacon <will@kernel.org> > --- > arch/arm64/include/asm/stacktrace.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/include/asm/stacktrace.h b/arch/arm64/include/asm/stacktrace.h > index 6564a01cc085..686731b9df05 100644 > --- a/arch/arm64/include/asm/stacktrace.h > +++ b/arch/arm64/include/asm/stacktrace.h > @@ -47,6 +47,10 @@ struct stack_info { > * @prev_type: The type of stack this frame record was on, or a synthetic > * value of STACK_TYPE_UNKNOWN. This is used to detect a > * transition from one stack to another. > + * > + * @kr_cur: When KRETPOLINES is selected, holds the kretprobe instance
As peter pointed out on IRC, this should be KRETPROBES, not KRETPOLINES (which does not exist as a Kconfig symbol).
I'll fix that for v2.
Mark.
> + * associated with the most recently encountered replacement lr > + * value. > */ > struct stackframe { > unsigned long fp; > -- > 2.11.0 >
|  |