Messages in this thread | | | From | Vincent Guittot <> | Date | Tue, 23 Nov 2021 09:38:40 +0100 | Subject | Re: [PATCH v2 2/2] sched/fair: Fix task_fits_capacity() capacity type |
| |
On Thu, 18 Nov 2021 at 15:15, Vincent Donnefort <vincent.donnefort@arm.com> wrote: > > capacity is an unsigned long value, compared with a task utilization which > is unsigned long as well. There's no need for an intermediate implicit > long cast. > > Fixes: 3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type") > Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 8fde6e10e24b..26a88975f68a 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -4070,7 +4070,8 @@ static inline void util_est_update(struct cfs_rq *cfs_rq, > trace_sched_util_est_se_tp(&p->se); > } > > -static inline int task_fits_capacity(struct task_struct *p, long capacity) > +static inline int task_fits_capacity(struct task_struct *p, > + unsigned long capacity) > { > return fits_capacity(uclamp_task_util(p), capacity); > } > -- > 2.25.1 >
| |