Messages in this thread | | | From | Ævar Arnfjörð Bjarmason <> | Subject | Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:' | Date | Wed, 24 Nov 2021 03:08:28 +0100 |
| |
On Tue, Nov 23 2021, Eric Wong wrote:
> Thorsten Leemhuis <linux@leemhuis.info> wrote: >> diff --git a/Documentation/maintainer/configure-git.rst b/Documentation/maintainer/configure-git.rst >> index 80ae5030a590..8429d45d661c 100644 >> --- a/Documentation/maintainer/configure-git.rst >> +++ b/Documentation/maintainer/configure-git.rst > > <snip>, +cc git@vger > >> @@ -56,7 +56,7 @@ by adding the following hook into your git: >> $ cat >.git/hooks/applypatch-msg <<'EOF' >> #!/bin/sh >> . git-sh-setup >> - perl -pi -e 's|^Message-Id:\s*<?([^>]+)>?$|Link: https://lore.kernel.org/r/$1|g;' "$1" >> + perl -pi -e 's|^Message-Id:\s*<?([^>]+)>?$|Reviewed: https://lore.kernel.org/r/$1|g;' "$1" > > Side note: that regexp should match "Message-ID" case-insensitively. > git send-email is an outlier in its capitalization of "Message-Id", > most RFCs capitalize it "Message-ID", as do common MUAs. > > git send-email's capitalization does annoy me and I've looked > into changing it; but there's a bunch of tests and probably > dependent code that also need to be updated...
"git format-patch" does it without send-email, but I see that send-email will then parse its output, and would turn any capitalization into the "Message-Id" form again.
We could probably just have it preserve whatever capitalization it finds if there's an existing header, we wouldn't fix anything, but we'd move the blame around a bit :)
| |