Messages in this thread | | | Date | Tue, 23 Nov 2021 15:49:22 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH 01/17] bitfield: Add non-constant field_{prep,get}() helpers |
| |
On Tue, 23 Nov 2021 17:24:15 +0100 Johannes Berg wrote: > > (*_replace_bits() seems to be useful, though) > > Indeed. > > Also as I said in my other mail, the le32/be32/... variants are > tremendously useful, and they fundamentally cannot be expressed with the > FIELD_GET() or field_get() macros. IMHO this is a clear advantage to the
Can you elaborate?
> typed versions, and if you ask me we should get rid of the FIELD_GETand > FIELD_PREP entirely - difficult now, but at least let's not propagate > that?
I don't see why.
| |