lkml.org 
[lkml]   [2021]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty: serial: imx: clear RTSD status before suspend
On Tue, Nov 23, 2021 at 03:03:49PM +0800, Sherry Sun wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
>
> Clear RTSD status before suspend due to the port also
> use RTS pin as wakeup source, need to clear the flag first.

I'd write:

Clear RTSD status before enabling the irq event for RTSD.

That this happens in the context of suspend isn't that important.

> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
> drivers/tty/serial/imx.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 90f82e6c54e4..fb75e3e0d828 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -2482,10 +2482,12 @@ static void imx_uart_enable_wakeup(struct imx_port *sport, bool on)
>
> if (sport->have_rtscts) {
> u32 ucr1 = imx_uart_readl(sport, UCR1);
> - if (on)
> + if (on) {
> + imx_uart_writel(sport, USR1_RTSD, USR1);
> ucr1 |= UCR1_RTSDEN;
> - else
> + } else {
> ucr1 &= ~UCR1_RTSDEN;
> + }
> imx_uart_writel(sport, ucr1, UCR1);
> }

The change looks fine.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-11-23 08:43    [W:0.089 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site