Messages in this thread | | | Date | Mon, 22 Nov 2021 19:52:08 +0000 | From | Sean Christopherson <> | Subject | Re: [PATCH 2/4] selftests: sev_migrate_tests: add tests for KVM_CAP_VM_COPY_ENC_CONTEXT_FROM |
| |
On Wed, Nov 17, 2021, Peter Gonda wrote: > On Wed, Nov 17, 2021 at 9:38 AM Paolo Bonzini <pbonzini@redhat.com> wrote: > > +static void test_sev_mirror(bool es) > > +{ > > + struct kvm_vm *src_vm, *dst_vm; > > + struct kvm_sev_launch_start start = { > > + .policy = es ? SEV_POLICY_ES : 0 > > + }; > > + int i; > > + > > + src_vm = sev_vm_create(es); > > + dst_vm = aux_vm_create(false); > > + > > + sev_mirror_create(dst_vm->fd, src_vm->fd); > > + > > + /* Check that we can complete creation of the mirror VM. */ > > + for (i = 0; i < NR_MIGRATE_TEST_VCPUS; ++i) > > + vm_vcpu_add(dst_vm, i); > > Style question. I realized I didn't do this myself but should there > always be blank line after these conditionals/loops without {}s? Tom > had me add them to work in ccp driver, unsure if that should be > maintained everywhere.
Generally speaking, yes. There will inevitably be exceptions where it's ok to omit a blank line, e.g. kvm_ioapic_clear_all() is a decent example, as is kvm_update_dr0123(). But for something like this where the for-loop is a different "block" than the following code, a blank line is preferred.
| |