Messages in this thread Patch in this message | | | From | Petr Mladek <> | Subject | [PATCH 3/5] printk/console: Remove unnecessary need_default_console manipulation | Date | Mon, 22 Nov 2021 14:26:47 +0100 |
| |
There is no need to clear @need_default_console when a console preferred by the command line, device tree, or SPCR, gets enabled.
The code is called only when some non-braille console matched a console in @console_cmdline array. It means that a non-braille console was added in __add_preferred_console() and the variable preferred_console is set to a number >= 0. As a result, @need_default_console is always set to "false" in the magic condition:
if (need_default_console || bcon || !console_drivers) need_default_console = preferred_console < 0;
This is one small step in removing the above magic condition that is hard to follow.
The patch removes one superfluous assignment and should not change the functionality.
Signed-off-by: Petr Mladek <pmladek@suse.com> --- kernel/printk/printk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 4c5f496877b0..3f845daa3a4a 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2892,10 +2892,8 @@ static int try_enable_preferred_console(struct console *newcon, return err; } newcon->flags |= CON_ENABLED; - if (i == preferred_console) { + if (i == preferred_console) newcon->flags |= CON_CONSDEV; - need_default_console = false; - } return 0; } -- 2.26.2
| |