Messages in this thread | | | Date | Mon, 22 Nov 2021 13:48:49 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH 3/4] regulators: irq_helper: Provide helper for trivial IRQ notifications |
| |
On Mon, Nov 22, 2021 at 01:04:12PM +0200, Matti Vaittinen wrote: > Provide a generic map_event helper for regulators which have a notification > IRQ with single, well defined purpose. Eg, IRQ always indicates exactly one > event for exactly one regulator device. For such IRQs the mapping is > trivial.
...
> + int err = rid->states[0].possible_errs;
I would rather make it unsigned, but anyway...
> + !single_bit_set(err, sizeof(err) * 8)))
hweight32() seems suitable here.
-- With Best Regards, Andy Shevchenko
| |