Messages in this thread | | | From | Xin Hao <> | Subject | Re: [PATCH V1 1/2] mm/damon/dbgfs: Modify Damon dbfs interface dependency in Kconfig | Date | Sun, 21 Nov 2021 21:19:57 +0800 |
| |
Hi Park,
On 11/21/21 7:24 PM, SeongJae Park wrote: > Hi Xin, > > On Sun, 21 Nov 2021 01:27:53 +0800 Xin Hao <xhao@linux.alibaba.com> wrote: > >> If you want to support "DAMON_DBGFS" in config file, it only depends on >> any one of "DAMON_VADDR" and "DAMON_PADDR". > This is not true. DAMON_DBGFS really depends on both. > > This patch even makes the build fails with some configs. > > CC mm/damon/dbgfs.o > linux/mm/damon/dbgfs.c: In function ‘dbgfs_target_ids_write’: > linux/mm/damon/dbgfs.c:409:3: error: implicit declaration of function ‘damon_pa_set_primitives’; did you mean ‘damon_va_set_primitives’? [-Werror=implicit-function-declaration] > damon_pa_set_primitives(ctx); > ^~~~~~~~~~~~~~~~~~~~~~~ > damon_va_set_primitives > cc1: some warnings being treated as errors
That is my fault, i have found a solution, and i will send a v2 patch to solve it, i I think DAMON_VADDR and DAMON_PADDR
must be decoupled,the kconfig must support it, becasue sometimes i don't want to use damon paddr function, just only need to include
DAMON_VADDR, therefore, it is not necessary to include damon/paddr.c during compile time.
> > > Thanks, > SJ > >> Signed-off-by: Xin Hao <xhao@linux.alibaba.com> >> --- >> mm/damon/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig >> index 5bcf05851ad0..971ffc496596 100644 >> --- a/mm/damon/Kconfig >> +++ b/mm/damon/Kconfig >> @@ -54,7 +54,7 @@ config DAMON_VADDR_KUNIT_TEST >> >> config DAMON_DBGFS >> bool "DAMON debugfs interface" >> - depends on DAMON_VADDR && DAMON_PADDR && DEBUG_FS >> + depends on DAMON_VADDR || DAMON_PADDR && DEBUG_FS >> help >> This builds the debugfs interface for DAMON. The user space admins >> can use the interface for arbitrary data access monitoring. >> -- >> 2.31.0 >> >> -- Best Regards! Xin Hao
| |