Messages in this thread | | | From | Christophe JAILLET <> | Subject | Re: [PATCH linux-next] drm/i915/request: Remove unused variables | Date | Sun, 21 Nov 2021 13:18:09 +0100 |
| |
Le 21/11/2021 à 11:13, cgel.zte@gmail.com a écrit : > From: yong yiran <yong.yiran@zte.com.cn> > > The clang_analyzer complains as follows: > drivers/gpu/drm/i915/i915_request.c:2119:2 warning: > Value stored to 'x' is never read > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: yong yiran <yong.yiran@zte.com.cn> > --- > drivers/gpu/drm/i915/i915_request.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c > index 820a1f38b271..5e4420f461e9 100644 > --- a/drivers/gpu/drm/i915/i915_request.c > +++ b/drivers/gpu/drm/i915/i915_request.c > @@ -2047,7 +2047,6 @@ void i915_request_show(struct drm_printer *m, > { > const char *name = rq->fence.ops->get_timeline_name((struct dma_fence *)&rq->fence); > char buf[80] = ""; > - int x = 0; > > /* > * The prefix is used to show the queue status, for which we use > @@ -2079,8 +2078,6 @@ void i915_request_show(struct drm_printer *m, > * from the lists > */ > > - x = print_sched_attr(&rq->sched.attr, buf, x, sizeof(buf)); > -
Seriously?
CJ
> drm_printf(m, "%s%.*s%c %llx:%lld%s%s %s @ %dms: %s\n", > prefix, indent, " ", > queue_status(rq), >
| |