Messages in this thread | | | From | Joakim Zhang <> | Subject | RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec | Date | Mon, 22 Nov 2021 02:08:28 +0000 |
| |
Hi Peng,
> -----Original Message----- > From: Peng Fan <peng.fan@nxp.com> > Sent: 2021年11月22日 9:04 > To: Andrew Lunn <andrew@lunn.ch>; Peng Fan (OSS) > <peng.fan@oss.nxp.com> > Cc: robh+dt@kernel.org; Aisheng Dong <aisheng.dong@nxp.com>; Joakim > Zhang <qiangqing.zhang@nxp.com>; davem@davemloft.net; > kuba@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx > <linux-imx@nxp.com>; netdev@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org > Subject: RE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec > > > Subject: Re: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec > > > > > +&fec { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_enet>; > > > + phy-mode = "rmii"; > > > > Is this really a Fast Ethernet? Not 1G? > > Not 1G. it only support 10M/100M ethernet. > > > > > > + phy-handle = <ðphy>; > > > + status = "okay"; > > > + > > > + mdio { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + ethphy: ethernet-phy { > > > + reg = <1>; > > > > I'm surprised this does not give warnings from the DTS tools. There is > > a reg value, so it should be ethernet-phy@1 > > I not see warning per my build: > " > *** Default configuration is based on 'defconfig' > # > # No change to .config > # > CALL scripts/atomic/check-atomics.sh > CALL scripts/checksyscalls.sh > CHK include/generated/compile.h > DTC arch/arm64/boot/dts/freescale/imx8ulp-evk.dtb > " > Anyway I will check and fix if the node needs a fix.
According to PHY guide, Documentation/devicetree/bindings/net/ethernet-phy.yaml, yes, we need write to ' ethernet-phy@1'.
DTS tool may not complain it, I guess 'make dtbs_check' could give a warning...
Best Regards, Joakim Zhang > Thanks, > Peng > > > > > Andrew
| |