lkml.org 
[lkml]   [2021]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
Date
> Subject: Re: [PATCH 4/4] arm64: dts: imx8ulp-evk: enable fec
>
> > +&fec {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_enet>;
> > + phy-mode = "rmii";
>
> Is this really a Fast Ethernet? Not 1G?

Not 1G. it only support 10M/100M ethernet.

>
> > + phy-handle = <&ethphy>;
> > + status = "okay";
> > +
> > + mdio {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ethphy: ethernet-phy {
> > + reg = <1>;
>
> I'm surprised this does not give warnings from the DTS tools. There is a reg
> value, so it should be ethernet-phy@1

I not see warning per my build:
"
*** Default configuration is based on 'defconfig'
#
# No change to .config
#
CALL scripts/atomic/check-atomics.sh
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
DTC arch/arm64/boot/dts/freescale/imx8ulp-evk.dtb
"
Anyway I will check and fix if the node needs a fix.

Thanks,
Peng

>
> Andrew

\
 
 \ /
  Last update: 2021-11-22 02:05    [W:0.058 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site