Messages in this thread | | | Subject | Re: [PATCH v2 2/2] clk: samsung: exynos850: Implement CMU_APM domain | From | Sylwester Nawrocki <> | Date | Sat, 20 Nov 2021 13:25:57 +0100 |
| |
On 23.10.2021 00:45, Sam Protsenko wrote: > CMU_APM clock domain provides clocks for APM IP-core (Active Power > Management). According to Exynos850 TRM, CMU_APM generates I3C, Mailbox, > Speedy, Timer, WDT, RTC and PMU clocks for BLK_ALIVE. > > This patch adds next clocks: > - bus clocks in CMU_TOP needed for CMU_APM > - all internal CMU_APM clocks > - leaf clocks for I3C, Speedy and RTC IP-cores > - bus clocks for CMU_CMGP and CMU_CHUB > > CMU_APM doesn't belong to Power Domains, but platform driver is used for > its registration to keep its bus clock always running. Otherwise rtc-s3c > driver disables that clock and system freezes. > > Signed-off-by: Sam Protsenko<semen.protsenko@linaro.org> > Reviewed-by: Krzysztof Kozlowski<krzysztof.kozlowski@canonical.com> > --- > Changes in v2: > - Reworked clock IDs to be contiguous (don't break ABI) > - Added R-b tag by Krzysztof Kozlowski > > drivers/clk/samsung/clk-exynos850.c | 142 +++++++++++++++++++++++++-
> include/dt-bindings/clock/exynos850.h | 29 +++++-
Looks good, could you just resend with the DT binding header changes moved to the first patch?
Regards, Sylwester
| |