Messages in this thread Patch in this message | | | From | "Alex Xu (Hello71)" <> | Subject | [PATCH 2/2] kbuild: pass --stream-size --no-content-size to zstd | Date | Sat, 20 Nov 2021 11:53:49 -0500 |
| |
Otherwise, it allocates 2 GB of memory at once. Even though the majority of this memory is never touched, the default heuristic overcommit refuses this request if less than 2 GB of RAM+swap is currently available. This results in "zstd: error 11 : Allocation error : not enough memory" and the kernel failing to build.
When the size is specified, zstd will reduce the memory request appropriately. For typical kernel sizes of ~32 MB, the largest mmap request will be reduced to 512 MB, which will succeed on all but the smallest devices.
For inputs around this size, --stream-size --no-content-size may slightly decrease the compressed size, or slightly increase it: https://github.com/facebook/zstd/issues/2848.
Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca> --- scripts/Makefile.lib | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index ca901814986a..13d756fbcdc7 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -468,10 +468,10 @@ quiet_cmd_xzmisc = XZMISC $@ # be used because it would require zstd to allocate a 128 MB buffer. quiet_cmd_zstd = ZSTD $@ - cmd_zstd = { cat $(real-prereqs) | $(ZSTD) -19; $(size_append); } > $@ + cmd_zstd = { cat $(real-prereqs) | $(ZSTD) --stream-size=$(total_size) --no-content-size -19; $(size_append); } > $@ quiet_cmd_zstd22 = ZSTD22 $@ - cmd_zstd22 = { cat $(real-prereqs) | $(ZSTD) -22 --ultra; $(size_append); } > $@ + cmd_zstd22 = { cat $(real-prereqs) | $(ZSTD) --stream-size=$(total_size) --no-content-size -22 --ultra; $(size_append); } > $@ # ASM offsets # --------------------------------------------------------------------------- -- 2.34.0
| |