lkml.org 
[lkml]   [2021]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH -next 2/2] sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
    From
    On 11/20/21 00:43, Sergei Shtylyov wrote:
    >> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
    >> index 30759fd1c3a2..011daac4a14e 100644
    >> --- a/drivers/ata/sata_fsl.c
    >> +++ b/drivers/ata/sata_fsl.c
    >> @@ -1493,7 +1493,7 @@ static int sata_fsl_probe(struct platform_device *ofdev)
    >> host_priv->ssr_base = ssr_base;
    >> host_priv->csr_base = csr_base;
    >>
    >> - irq = irq_of_parse_and_map(ofdev->dev.of_node, 0);
    >> + irq = platform_get_irq(ofdev, 0);
    >> if (!irq) {
    >
    > if (irq < 0) {
    >
    > platform_get_irq() returns negative error codes, not 0 on failure.

    Sergei,

    By the way, the kdoc comment for platform_get_irq() says:

    "Return: non-zero IRQ number on success, negative error number on failure."

    But irq 0 is valid, isn't it ? So shouldn't this be changed to something
    like:

    "Return: IRQ number on success, negative error number on failure."

    --
    Damien Le Moal
    Western Digital Research

    \
     
     \ /
      Last update: 2021-11-20 07:09    [W:2.640 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site