lkml.org 
[lkml]   [2021]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging: r8188eu: os_dep: remove the goto statement
From
On 11/2/21 19:40, Saurav Girepunje wrote:
>
>
> On 01/11/21 12:57 am, Pavel Skripkin wrote:
>> On 10/31/21 22:24, Pavel Skripkin wrote:
>>>> I think rtw_init_default_value should return void. It's return value is not useful.
>>>
>>>
>>> Sure, but you need to firstly remove
>>> `ret8 = rtw_init_default_value(padapter);` and then make it return bool
>>                                      ^^^^
>>
>> I mean void, of course :)
>>
>>
>> With regards,
>> Pavel Skripkin
>
> Intention for this patch to remove the goto statement. I think removing a local variable
> for return value and changing the return type of function can be one separate patch.
>
> On this patch intent to remove the goto statement only.
>

I agree, I've just pointed out to further possible code improvements :)



With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2021-11-02 21:21    [W:0.041 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site