Messages in this thread | | | Date | Tue, 2 Nov 2021 23:20:52 +0300 | Subject | Re: [PATCH] staging: r8188eu: os_dep: remove the goto statement | From | Pavel Skripkin <> |
| |
On 11/2/21 19:40, Saurav Girepunje wrote: > > > On 01/11/21 12:57 am, Pavel Skripkin wrote: >> On 10/31/21 22:24, Pavel Skripkin wrote: >>>> I think rtw_init_default_value should return void. It's return value is not useful. >>> >>> >>> Sure, but you need to firstly remove >>> `ret8 = rtw_init_default_value(padapter);` and then make it return bool >> ^^^^ >> >> I mean void, of course :) >> >> >> With regards, >> Pavel Skripkin > > Intention for this patch to remove the goto statement. I think removing a local variable > for return value and changing the return type of function can be one separate patch. > > On this patch intent to remove the goto statement only. >
I agree, I've just pointed out to further possible code improvements :)
With regards, Pavel Skripkin
| |