Messages in this thread Patch in this message | | | Date | Tue, 02 Nov 2021 16:11:40 -0400 | From | Steven Rostedt <> | Subject | [for-next][PATCH 14/14] ftrace/samples: Add missing prototype for my_direct_func |
| |
From: Jiri Olsa <jolsa@redhat.com>
There's compilation fail reported kernel test robot for W=1 build:
>> samples/ftrace/ftrace-direct-multi.c:8:6: warning: no previous prototype for function 'my_direct_func' [-Wmissing-prototypes] void my_direct_func(unsigned long ip)
The inlined assembly is used outside function, so we can't make my_direct_func static and pass it as asm input argument.
However my_tramp is already extern so I think there's no problem keeping my_direct_func extern as well and just add its prototype.
Link: https://lkml.kernel.org/r/20211101153907.377668-1-jolsa@kernel.org
Reported-by: kernel test robot <lkp@intel.com> Fixes: 5fae941b9a6f ("ftrace/samples: Add multi direct interface test module") Signed-off-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> --- samples/ftrace/ftrace-direct-multi.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/samples/ftrace/ftrace-direct-multi.c b/samples/ftrace/ftrace-direct-multi.c index 2a5b1fb7ac14..b6d7806b400e 100644 --- a/samples/ftrace/ftrace-direct-multi.c +++ b/samples/ftrace/ftrace-direct-multi.c @@ -5,6 +5,8 @@ #include <linux/ftrace.h> #include <linux/sched/stat.h> +extern void my_direct_func(unsigned long ip); + void my_direct_func(unsigned long ip) { trace_printk("ip %lx\n", ip); -- 2.33.0
| |