lkml.org 
[lkml]   [2021]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v7 4/6] reset: Add Delta TN48M CPLD reset controller
    On Tue, Nov 2, 2021 at 6:57 PM Robert Marko <robert.marko@sartura.hr> wrote:
    >
    > Delta TN48M CPLD exposes resets for the following:
    > * 88F7040 SoC
    > * 88F6820 SoC
    > * 98DX3265 switch MAC-s
    > * 88E1680 PHY-s
    > * 88E1512 PHY
    > * PoE PSE controller
    >
    > Controller supports only self clearing resets.

    ...

    > +#include <linux/device.h>
    > +#include <linux/kernel.h>
    > +#include <linux/module.h>

    > +#include <linux/of.h>

    I haven't found any user of this header, but mod_devicetable.h is missing.

    > +#include <linux/platform_device.h>
    > +#include <linux/regmap.h>
    > +#include <linux/reset-controller.h>

    > +#include <dt-bindings/reset/delta,tn48m-reset.h>

    Shouldn't this go before linux/* as it provides more generic definitions?

    ...

    > +#define TN48M_RESET_TIMEOUT 125000
    > +#define TN48M_RESET_SLEEP 10

    In which units? (both)

    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2021-11-02 20:33    [W:4.171 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site