lkml.org 
[lkml]   [2021]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V3 4/4] crypto: ccp - Add SEV_INIT_EX support
From
Date
On 11/2/21 9:23 AM, Peter Gonda wrote:
> From: David Rientjes <rientjes@google.com>
>
> +
> + nread = kernel_read(fp, sev_init_ex_nv_address, NV_LENGTH, NULL);

Not sure if you missed the previous comment, but kernel_read can return an
error, shouldn't it be checked and fail on error?

Thanks,
Tom

> + dev_dbg(psp_master->dev, "SEV: read %ld bytes from NV file\n", nread);
> + filp_close(fp, NULL);
> +
> + return 0;
> +}
> +

\
 
 \ /
  Last update: 2021-11-02 16:39    [W:0.916 / U:2.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site