Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 2 Nov 2021 16:44:09 +0200 | Subject | Re: [BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from atomisp_video_pipe |
| |
On Tue, Nov 2, 2021 at 3:10 PM Dan Carpenter <dan.carpenter@oracle.com> wrote: > On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote:
> > + if(!pipe->asd) { > > Run your patches through scripts/checkpatch.pl.
While it's good advice, we are dealing with quite a bad code under staging, so the requirements may be relaxed.
> > + dev_err(pipe->isp->dev, "%s(): asd is NULL, device is %s\n", > > + __func__, pipe->vdev.name); > > + return; > > + }
-- With Best Regards, Andy Shevchenko
| |