Messages in this thread | | | Date | Tue, 2 Nov 2021 14:15:26 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH 02/21] block: Add bio_add_folio() |
| |
On Mon, Nov 01, 2021 at 02:51:37PM -0600, Jens Axboe wrote: > On 11/1/21 2:39 PM, Matthew Wilcox (Oracle) wrote: > > This is a thin wrapper around bio_add_page(). The main advantage here > > is the documentation that stupidly large folios are not supported. > > It's not currently possible to allocate stupidly large folios, but if > > it ever becomes possible, this function will fail gracefully instead of > > doing I/O to the wrong bytes. > > Might be better with UINT_MAX instead of stupidly here, because then > it immediately makes sense. Can you make a change to that effect?
I'll make it "that folios larger than 2GiB are not supported. It's not currently possible to allocate folios that large,"
> With that: > > Reviewed-by: Jens Axboe <axboe@kernel.dk> > > -- > Jens Axboe >
| |