lkml.org 
[lkml]   [2021]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/21] block: Add bio_add_folio()
    On Mon, Nov 01, 2021 at 02:51:37PM -0600, Jens Axboe wrote:
    > On 11/1/21 2:39 PM, Matthew Wilcox (Oracle) wrote:
    > > This is a thin wrapper around bio_add_page(). The main advantage here
    > > is the documentation that stupidly large folios are not supported.
    > > It's not currently possible to allocate stupidly large folios, but if
    > > it ever becomes possible, this function will fail gracefully instead of
    > > doing I/O to the wrong bytes.
    >
    > Might be better with UINT_MAX instead of stupidly here, because then
    > it immediately makes sense. Can you make a change to that effect?

    I'll make it "that folios larger than 2GiB are not supported. It's not
    currently possible to allocate folios that large,"

    > With that:
    >
    > Reviewed-by: Jens Axboe <axboe@kernel.dk>
    >
    > --
    > Jens Axboe
    >

    \
     
     \ /
      Last update: 2021-11-02 15:17    [W:2.317 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site