lkml.org 
[lkml]   [2021]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/17] media: atomisp: pci: use IA_CSS_ERROR() for error messages in sh_css_mipi.c
    On Mon, Oct 18, 2021 at 01:19:46AM +0900, Tsuchiya Yuto wrote:
    > .../staging/media/atomisp/pci/sh_css_mipi.c | 32 ++++++++-----------
    > 1 file changed, 13 insertions(+), 19 deletions(-)
    >
    > diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
    > index c1f2f6151c5f..de56a1da754d 100644
    > --- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
    > +++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
    > @@ -434,9 +434,8 @@ allocate_mipi_frames(struct ia_css_pipe *pipe,
    >
    > if ((!IS_ISP2401 && port >= N_CSI_PORTS) ||
    > (IS_ISP2401 && err)) {
    > - ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE,
    > - "allocate_mipi_frames(%p) exit: error: port is not correct (port=%d).\n",
    > - pipe, port);
    > + IA_CSS_ERROR("allocate_mipi_frames(%p) exit: port is not correct (port=%d).",
    > + pipe, port);

    Not related to this patch but these printks should be using __func__
    instead of hard coding it.

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2021-11-02 12:37    [W:4.547 / U:1.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site