lkml.org 
[lkml]   [2021]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/13] nvdimm/blk: avoid calling del_gendisk() on early failures
    On Fri, Oct 15, 2021 at 05:13:48PM -0700, Dan Williams wrote:
    > On Fri, Oct 15, 2021 at 4:53 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
    > >
    > > If nd_integrity_init() fails we'd get del_gendisk() called,
    > > but that's not correct as we should only call that if we're
    > > done with device_add_disk(). Fix this by providing unwinding
    > > prior to the devm call being registered and moving the devm
    > > registration to the very end.
    > >
    > > This should fix calling del_gendisk() if nd_integrity_init()
    > > fails. I only spotted this issue through code inspection. It
    > > does not fix any real world bug.
    > >
    >
    > Just fyi, I'm preparing patches to delete this driver completely as it
    > is unused by any shipping platform. I hope to get that removal into
    > v5.16.

    Curious if are you going to nuking it on v5.16? Otherwise it would stand
    in the way of the last few patches to add __must_check for the final
    add_disk() error handling changes.

    Luis

    \
     
     \ /
      Last update: 2021-11-03 01:13    [W:2.375 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site