Messages in this thread | | | Subject | Re: [PATCH] selftests: vDSO: parse: warning: fix assignment as a condition | From | Shuah Khan <> | Date | Fri, 19 Nov 2021 17:16:47 -0700 |
| |
On 11/5/21 2:17 PM, Nick Desaulniers wrote: > On Fri, Nov 5, 2021 at 9:28 AM Anders Roxell <anders.roxell@linaro.org> wrote: >> >> When building selftests/vDSO with clang the following warning shows up: >> >> clang -std=gnu99 -Wno-pointer-sign vdso_test_gettimeofday.c parse_vdso.c -o /home/anders/.cache/tuxmake/builds/current/kselftest/vDSO/vdso_test_gettimeofday >> parse_vdso.c:65:9: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] >> if (g = h & 0xf0000000) >> ~~^~~~~~~~~~~~~~~~ >> >> Rework to a parentheses before doing the check. >> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > > Thanks for the patch! > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> >
My commit script failed due to checkpatch warns. Run checkpatchp.l --strict to find the problems and send me the fixed version.
thanks, -- Shuah
| |