lkml.org 
[lkml]   [2021]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] dmaengine: ti: edma: Use 'for_each_set_bit' when possible
From


On 18/11/2021 21:28, Christophe JAILLET wrote:
> Use 'for_each_set_bit()' instead of hand wrinting it. It is much less
> version.

Thanks for the patch!

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>


> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/dma/ti/edma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> index caa4050ecc02..08e47f44d325 100644
> --- a/drivers/dma/ti/edma.c
> +++ b/drivers/dma/ti/edma.c
> @@ -1681,8 +1681,7 @@ static irqreturn_t dma_ccerr_handler(int irq, void *data)
>
> dev_dbg(ecc->dev, "EMR%d 0x%08x\n", j, val);
> emr = val;
> - for (i = find_first_bit(&emr, 32); i < 32;
> - i = find_next_bit(&emr, 32, i + 1)) {
> + for_each_set_bit(i, &emr, 32) {
> int k = (j << 5) + i;
>
> /* Clear the corresponding EMR bits */
>

--
Péter

\
 
 \ /
  Last update: 2021-11-19 20:59    [W:0.113 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site