Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 18 Nov 2021 18:46:20 +0100 | Subject | Re: [PATCH 3/4] clk: renesas: cpg-mssr: Check return value of pm_genpd_init() |
| |
Hi Sergey,
On Thu, Nov 18, 2021 at 6:44 PM Sergey Shtylyov <s.shtylyov@omp.ru> wrote: > On 11/18/21 6:29 PM, Geert Uytterhoeven wrote: > > [...] > >> Make sure we check the return value of pm_genpd_init() which might fail. > >> Also add a devres action to remove the power-domain in-case the probe > >> callback fails further down in the code flow. > >> > >> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > i.e. will queue in renesas-clk-for-v5.17. > > > >> @@ -574,7 +580,13 @@ static int __init cpg_mssr_add_clk_domain(struct device *dev, > >> GENPD_FLAG_ACTIVE_WAKEUP; > >> genpd->attach_dev = cpg_mssr_attach_dev; > >> genpd->detach_dev = cpg_mssr_detach_dev; > >> - pm_genpd_init(genpd, &pm_domain_always_on_gov, false); > >> + ret = pm_genpd_init(genpd, &pm_domain_always_on_gov, false); > >> + if (ret) > >> + return ret; > >> + ret = devm_add_action_or_reset(dev, cpg_mssr_genpd_remove, genpd); > > > > Will insert a blank line here. > > You mean after *return*? Else I don't think we need an empty line. :-)
Meh, fortunately I'm better at making the actual code change ;-)
> > > > >> + if (ret) > >> + return ret; > >> + > >> cpg_mssr_clk_domain = pd; > >> > >> of_genpd_add_provider_simple(np, genpd);
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |