Messages in this thread | | | Date | Thu, 18 Nov 2021 09:20:49 -0800 | From | Kees Cook <> | Subject | Re: [PATCH v2] ARM: socfpga: Fix crash with CONFIG_FORTIRY_SOURCE |
| |
On Thu, Nov 18, 2021 at 03:25:08PM +0100, Takashi Iwai wrote: > When CONFIG_FORTIFY_SOURCE is set, memcpy() checks the potential > buffer overflow and panics. The code in sofcpga bootstrapping > contains the memcpy() calls are mistakenly translated as the shorter > size, hence it triggers a panic as if it were overflowing. > > This patch changes the secondary_trampoline and *_end definitions > to arrays for avoiding the false-positive crash above. > > Suggested-by: Kees Cook <keescook@chromium.org> > Buglink: https://bugzilla.suse.com/show_bug.cgi?id=1192473 > Link: https://lore.kernel.org/r/20211117193244.31162-1-tiwai@suse.de > Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reviewed-by: Kees Cook <keescook@chromium.org>
Thanks!
-- Kees Cook
| |