Messages in this thread | | | Date | Thu, 18 Nov 2021 09:09:38 -0800 | Subject | Re: [PATCH] skbuff: suppress clang object-size-mismatch error | From | Tadeusz Struk <> |
| |
On 11/18/21 08:38, Jakub Kicinski wrote: > On Thu, 18 Nov 2021 08:05:01 -0800 Tadeusz Struk wrote: >> On 11/12/21 07:42, David Miller wrote: >>> From: Jakub Kicinski <kuba@kernel.org> >>> Date: Thu, 11 Nov 2021 09:54:44 -0800 >>> >>>> I'm not sure if that stalled due to lack of time or some fundamental >>>> problems. >>> >>> ran out of time, then had a stroke... >>> >>>> Seems like finishing that would let us clean up such misuses? >>> >>> yes it would >> >> so since there is not better way of suppressing the issue atm are >> you ok with taking this fix for now? > > I vote no on sprinkling ugly tags around to silence some random > checkers warning. We already have too many of them. They are > meaningless and confusing to people reading the code. > > This is not a fundamental problem, the solution is clear. >
Fair enough.
David, did you post your work somewhere if someone would like to pick it up and finish it?
-- Thanks, Tadeusz
| |