lkml.org 
[lkml]   [2021]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] gpiolib: check the 'ngpios' property in core gpiolib code
On Thu, Nov 18, 2021 at 07:01:42PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 18, 2021 at 05:38:14PM +0100, Bartosz Golaszewski wrote:
> > On Thu, Nov 18, 2021 at 4:46 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Thu, Nov 18, 2021 at 02:23:17PM +0100, Bartosz Golaszewski wrote:

...

> > > > + if (ret) {

> > > > + ret = -EINVAL;
> > >
> > > Sorry, forgot to ask, why this is needed?
> >
> > What do you mean? 0 lines doesn't sound like a valid value so -EINVAL
> > is in order.
>
> What is so special about -EINVAL? Why ret can't be returned?

See another mail, I explained how the code should be.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-11-18 18:08    [W:0.045 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site