lkml.org 
[lkml]   [2021]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/2] gpiolib: check the 'ngpios' property in core gpiolib code
On Thu, Nov 18, 2021 at 4:46 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Thu, Nov 18, 2021 at 02:23:17PM +0100, Bartosz Golaszewski wrote:
> > Several drivers read the 'ngpios' device property on their own, but
> > since it's defined as a standard GPIO property in the device tree bindings
> > anyway, it's a good candidate for generalization. If the driver didn't
> > set its gc->ngpio, try to read the 'ngpios' property from the GPIO
> > device's firmware node before bailing out.
>
> Thanks for update, my comment below.
>
> ...
>
> > if (gc->ngpio == 0) {
> > - chip_err(gc, "tried to insert a GPIO chip with zero lines\n");
> > - ret = -EINVAL;
> > - goto err_free_descs;
> > + ret = device_property_read_u32(&gdev->dev, "ngpios", &ngpios);
> > + if (ret) {
> > + chip_err(gc, "tried to insert a GPIO chip with zero lines\n");
>
> > + ret = -EINVAL;
>
> Sorry, forgot to ask, why this is needed?
>

What do you mean? 0 lines doesn't sound like a valid value so -EINVAL
is in order.

Bart

\
 
 \ /
  Last update: 2021-11-18 17:39    [W:0.091 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site