Messages in this thread | | | Date | Thu, 18 Nov 2021 13:24:01 +0800 | From | Leo Yan <> | Subject | Re: [FYI][PATCH 1/1] perf tools: Set COMPAT_NEED_REALLOCARRAY for CONFIG_AUXTRACE=1 |
| |
On Wed, Nov 17, 2021 at 12:35:46PM -0300, Arnaldo Carvalho de Melo wrote:
[...]
> > I think we should apply below code as well, if COMPAT_NEED_REALLOCARRAY > > is enabled for AUXTRACE, it will be applied for cs-etm as well. For > > this reason, we can remove the redundant definition for CORESIGHT. > > Isn't it possible to ask for: > > make NO_AUXTRACE=1 CORESIGHT=1 > > ?
If AUXTRACE is disabled, then it has no chance to build cs-etm code; this is decided by util/Build:
ifdef CONFIG_LIBOPENCSD perf-$(CONFIG_AUXTRACE) += cs-etm.o perf-$(CONFIG_AUXTRACE) += cs-etm-decoder/ endif
So we could safely remove the redundant definition for COMPAT_NEED_REALLOCARRAY in CORESIGHT chunk.
Thanks, Leo
> > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > > index 07e65a061fd3..2dbf086d1155 100644 > > --- a/tools/perf/Makefile.config > > +++ b/tools/perf/Makefile.config > > @@ -477,9 +477,6 @@ ifdef CORESIGHT > > $(call feature_check,libopencsd) > > ifeq ($(feature-libopencsd), 1) > > CFLAGS += -DHAVE_CSTRACE_SUPPORT $(LIBOPENCSD_CFLAGS) > > - ifeq ($(feature-reallocarray), 0) > > - CFLAGS += -DCOMPAT_NEED_REALLOCARRAY > > - endif > > LDFLAGS += $(LIBOPENCSD_LDFLAGS) > > EXTLIBS += $(OPENCSDLIBS) > > $(call detected,CONFIG_LIBOPENCSD)
| |