lkml.org 
[lkml]   [2021]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 15/15] KVM: X86: Always set gpte_is_8_bytes when direct map
From
On 11/18/21 15:34, Lai Jiangshan wrote:
>
>
> On 2021/11/18 19:12, Paolo Bonzini wrote:
>> On 11/18/21 12:08, Lai Jiangshan wrote:
>>> From: Lai Jiangshan <laijs@linux.alibaba.com>
>>>
>>> When direct map, gpte_is_8_bytes has no meaning, but it is true for all
>>> other cases except direct map when nonpaping.
>>>
>>> Setting gpte_is_8_bytes to true when nonpaping can ensure that
>>> !gpte_is_8_bytes means 32-bit gptes for shadow paging.
>>
>> Then the right thing to do would be to rename it to has_4_byte_gptes
>> and invert the direction.  But as things stand, it's a bit more
>> confusing to make gpte_is_8_bytes=1 if there are no guest PTEs at all.
>>
>
> I will make the last 3 patches be a separated patchset and will do the
> rename.

Patches 13 and 14 are fine actually.

Paolo

\
 
 \ /
  Last update: 2021-11-18 16:02    [W:0.150 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site