lkml.org 
[lkml]   [2021]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS
+ Zhen & Vinay

This patch looks good in itself, but I would like to see a tested by
tag. At the very least testing for regression in single-link LVDS but
ideally some third party verification of this patch.

On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote:
>
> Fixed wrong register shift for single/dual link LVDS output.
>
> Signed-off-by: Jiri Vanek <jirivanek1@gmail.com>
> ---
> drivers/gpu/drm/bridge/tc358775.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
> index 2272adcc5b4a..1d6ec1baeff2 100644
> --- a/drivers/gpu/drm/bridge/tc358775.c
> +++ b/drivers/gpu/drm/bridge/tc358775.c
> @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val)
> }
>
> #define TC358775_LVCFG_LVDLINK__MASK 0x00000002
> -#define TC358775_LVCFG_LVDLINK__SHIFT 0
> +#define TC358775_LVCFG_LVDLINK__SHIFT 1
> static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
> {
> return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
> --
> 2.30.2
>

\
 
 \ /
  Last update: 2021-11-18 15:50    [W:0.856 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site