Messages in this thread | | | Subject | Re: [PATCH] x86/paravirt: Fix build PARAVIRT_XXL=y without XEN_PV | From | Juergen Gross <> | Date | Thu, 18 Nov 2021 07:23:51 +0100 |
| |
On 17.11.21 19:14, Kirill A. Shutemov wrote: > TDX is going to use CONFIG_PARAVIRT_XXL, but kernel fails to compile if > XEN_PV is not enabled: > > ld.lld: error: undefined symbol: xen_iret > > It happens because INTERRUPT_RETURN defined to use xen_iret if > CONFIG_PARAVIRT_XXL enabled regardless of CONFIG_XEN_PV. > > The issue is not visible in the current kernel because CONFIG_XEN_PV is > the only user of CONFIG_PARAVIRT_XXL and there's no way to enable them > separately. > > Rework code to define INTERRUPT_RETURN based on CONFIG_XEN_PV, not > CONFIG_PARAVIRT_XXL. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Deep Shah <sdeep@vmware.com> > Cc: "VMware, Inc." <pv-drivers@vmware.com>
I agree with the patch, so:
Reviewed-by: Juergen Gross <jgross@suse.com>
Nevertheless I believe that TDX should not switch to use PARAVIRT_XXL.
Juergen [unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |