lkml.org 
[lkml]   [2021]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] dt-bindings: media: document imx8mq support for imx7-csi
Hi Martin,

Thank you for the patch.

On Wed, Nov 17, 2021 at 10:27:10AM +0100, Martin Kepplinger wrote:
> Add the fsl,imx8mq-csi compatible string to the bindings for nxp,imx7-csi
> since the driver explicitly handles that now.

The commit message should describe why a different compatible string is
needed, without mentioning the driver, as DT bindings are not
driver-dependent.

With that fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
> Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> index 5922a2795167..4f7b78265336 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> @@ -17,6 +17,7 @@ properties:
> compatible:
> oneOf:
> - enum:
> + - fsl,imx8mq-csi
> - fsl,imx7-csi
> - fsl,imx6ul-csi
> - items:

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2021-11-17 18:20    [W:0.082 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site