Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 17 Nov 2021 19:13:54 +0200 | Subject | Re: [PATCH v10 0/5] Add Xilinx AMS Driver |
| |
On Wed, Nov 17, 2021 at 6:46 PM Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com> wrote: > > Add Xilinx AMS driver which is used for Xilinx's ZynqMP AMS controller. > This AMS driver is used to report various interface voltages and temperatures > across the system. > This driver will be used by iio-hwmon to repport voltages and temperatures > across the system by using various channel interfaces. > This driver handles AMS module including PS-Sysmon & PL-Sysmon. The binding > documentation is added for understanding of AMS, PS, PL Sysmon Channels.
Thanks and wait a bit, please. No need to send patches so often. We haven't settled down yet on v9. Here you effectively ignored my comment given again patch 5/5. Why?
...
> Changes in v10: > - Fixed licence in zynqmp.dtsi. > - Changed the macros to use BIT(). > - Realign some code to fit within 100 chars. > - Modified readl_poll_timeout usage.
> - Usage of array_size() instead of check_mul_overflow().
Why? I have asked you why you haven't used kcalloc there as well.
> - Usage of dev_err_probe() instead of dev_err(). > - Usage of kcalloc instead of kzalloc()
-- With Best Regards, Andy Shevchenko
| |