Messages in this thread | | | Date | Wed, 17 Nov 2021 11:05:57 -0500 | Subject | Re: [PATCH v2] xen: don't continue xenstore initialization in case of errors | From | Boris Ostrovsky <> |
| |
On 11/15/21 5:27 PM, Stefano Stabellini wrote: > From: Stefano Stabellini <stefano.stabellini@xilinx.com> > > In case of errors in xenbus_init (e.g. missing xen_store_gfn parameter), > we goto out_error but we forget to reset xen_store_domain_type to > XS_UNKNOWN. As a consequence xenbus_probe_initcall and other initcalls > will still try to initialize xenstore resulting into a crash at boot. > > [ 2.479830] Call trace: > [ 2.482314] xb_init_comms+0x18/0x150 > [ 2.486354] xs_init+0x34/0x138 > [ 2.489786] xenbus_probe+0x4c/0x70 > [ 2.498432] xenbus_probe_initcall+0x2c/0x7c > [ 2.503944] do_one_initcall+0x54/0x1b8 > [ 2.507358] kernel_init_freeable+0x1ac/0x210 > [ 2.511617] kernel_init+0x28/0x130 > [ 2.516112] ret_from_fork+0x10/0x20 > > Cc: <Stable@vger.kernel.org> > Cc: jbeulich@suse.com > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Applied to for-linus-5.16c
-boris
| |