lkml.org 
[lkml]   [2021]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 01/12] dt-bindings: watchdog: Require samsung,syscon-phandle for Exynos7
On Sun, Nov 07, 2021 at 10:29:32PM +0200, Sam Protsenko wrote:
> Exynos7 watchdog driver is clearly indicating that its dts node must
> define syscon phandle property. That was probably forgotten, so add it.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> Fixes: 2b9366b66967 ("watchdog: s3c2410_wdt: Add support for Watchdog device on Exynos7")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> Changes in v3:
> - Added R-b tag by Rob Herring
>
> Changes in v2:
> - Added R-b tag by Krzysztof Kozlowski
> - Added "Fixes" tag
>
> Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> index 76cb9586ee00..93cd77a6e92c 100644
> --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> @@ -39,8 +39,8 @@ properties:
> samsung,syscon-phandle:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> - Phandle to the PMU system controller node (in case of Exynos5250
> - and Exynos5420).
> + Phandle to the PMU system controller node (in case of Exynos5250,
> + Exynos5420 and Exynos7).
>
> required:
> - compatible
> @@ -58,6 +58,7 @@ allOf:
> enum:
> - samsung,exynos5250-wdt
> - samsung,exynos5420-wdt
> + - samsung,exynos7-wdt
> then:
> required:
> - samsung,syscon-phandle
> --
> 2.30.2
>

\
 
 \ /
  Last update: 2021-11-17 14:34    [W:0.267 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site