lkml.org 
[lkml]   [2021]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH linux-next] USB: Delete the useless assignment to "nbytes"
On Thu, Nov 11, 2021 at 03:11:24PM +0000, cgel.zte@gmail.com wrote:
> From: luo penghao <luo.penghao@zte.com.cn>
>
> The assignment of the local variable "nbytes" in the if statement
> will not be used
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
> ---
> drivers/usb/mon/mon_bin.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/mon/mon_bin.c b/drivers/usb/mon/mon_bin.c
> index f48a23a..b8ba0f7 100644
> --- a/drivers/usb/mon/mon_bin.c
> +++ b/drivers/usb/mon/mon_bin.c
> @@ -845,7 +845,6 @@ static ssize_t mon_bin_read(struct file *file, char __user *buf,
> mutex_unlock(&rp->fetch_lock);
> return -EFAULT;
> }
> - nbytes -= step_len;
> buf += step_len;
> rp->b_read += step_len;
> done += step_len;
> --
> 2.15.2
>
>

This patch is not correct (it's either wrong, or incomplete). Please
fix your "robot" to not send changes that you have not properly
verified.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-11-17 14:32    [W:0.046 / U:23.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site