Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Wed, 17 Nov 2021 10:36:45 +0000 | Subject | Re: [PATCH 2/2] arm64: dts: renesas: rzg2l-smarc: Enable RSPI1 on carrier board |
| |
Hi Geert,
On Wed, Nov 17, 2021 at 10:25 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Wed, Nov 17, 2021 at 11:16 AM Lad, Prabhakar > <prabhakar.csengg@gmail.com> wrote: > > On Wed, Nov 17, 2021 at 10:10 AM Geert Uytterhoeven > > <geert@linux-m68k.org> wrote: > > > On Wed, Nov 17, 2021 at 2:12 AM Lad Prabhakar > > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > > RSPI1 (SPI1) interface is available on PMOD0 connector (J1) on carrier > > > > board, This patch adds pinmux and spi1 node to carrier board dtsi file. > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > > > Thanks for your patch! > > > > > > > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > > > > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi > > > > @@ -31,6 +31,7 @@ > > > > i2c0 = &i2c0; > > > > i2c1 = &i2c1; > > > > i2c3 = &i2c3; > > > > + spi1 = &spi1; > > > > > > Do you mind if I drop this while applying? > > > > > Fine by me. Any reason to do so? (I ask because in future I can take > > care of it prior to posting) > > Aliases are used to match physical connectors with a device, so they > make sense for serial and network ports. > We don't have them for SPI on any Renesas arm64 boards. > We do have them for I2C, but I2C differs from SPI, as on I2C you can > instantiate new devices from sysfs. > Agreed makes sense now. Thank you for the clarification.
Cheers, Prabhakar
> Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |