Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 17 Nov 2021 09:57:05 +0100 | Subject | Re: [PATCH 3/3] spi: spi-rspi: Drop redeclaring ret variable in qspi_transfer_in() |
| |
On Wed, Nov 17, 2021 at 2:05 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > "ret" variable is already declared in qspi_transfer_in() at the > beginning of function, drop redeclaring ret in the if block, fixing > below: > > spi-rspi.c: In function ‘qspi_transfer_in’: > spi-rspi.c:838:7: warning: declaration of ‘ret’ shadows a previous local > 838 | int ret = rspi_dma_transfer(rspi, NULL, &xfer->rx_sg); > | ^~~ > spi-rspi.c:835:6: note: shadowed declaration is here > 835 | int ret; > > Fixes: db30083813b55 ("spi: rspi: avoid uninitialized variable access") > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |