lkml.org 
[lkml]   [2021]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [paulmck-rcu:dev.2021.11.10a 81/96] kernel/rcu/tasks.h:181:25: sparse: sparse: incorrect type in argument 1 (different modifiers)
On Thu, Nov 18, 2021 at 09:41:40AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2021.11.10a
> head: cfbd3769397911e7f1561fa57b4490b1e4fed9de
> commit: a3ecbdd6d841a025ebe87b79c7538b4dc44edc94 [81/96] rcu-tasks: Use spin_lock_rcu_node() and friends
> config: arm-randconfig-s032-20211115 (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.4-dirty
> # https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=a3ecbdd6d841a025ebe87b79c7538b4dc44edc94
> git remote add paulmck-rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> git fetch --no-tags paulmck-rcu dev.2021.11.10a
> git checkout a3ecbdd6d841a025ebe87b79c7538b4dc44edc94
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>

Good catch, a missing ACCESS_PRIVATE. Will fix, thank you!

Thanx, Paul

> sparse warnings: (new ones prefixed by >>)
> kernel/rcu/update.c: note: in included file:
> >> kernel/rcu/tasks.h:181:25: sparse: sparse: incorrect type in argument 1 (different modifiers) @@ expected struct raw_spinlock [usertype] *lock @@ got struct raw_spinlock [noderef] * @@
> kernel/rcu/tasks.h:181:25: sparse: expected struct raw_spinlock [usertype] *lock
> kernel/rcu/tasks.h:181:25: sparse: got struct raw_spinlock [noderef] *
>
> vim +181 kernel/rcu/tasks.h
>
> 165
> 166 // Initialize per-CPU callback lists for the specified flavor of
> 167 // Tasks RCU.
> 168 static void cblist_init_generic(struct rcu_tasks *rtp)
> 169 {
> 170 int cpu;
> 171 unsigned long flags;
> 172
> 173 raw_spin_lock_irqsave(&rtp->cbs_gbl_lock, flags);
> 174 rtp->percpu_enqueue_shift = ilog2(nr_cpu_ids);
> 175 for_each_possible_cpu(cpu) {
> 176 struct rcu_tasks_percpu *rtpcp = per_cpu_ptr(rtp->rtpcpu, cpu);
> 177
> 178 pr_info("%s initializing CPU %d rcu_tasks_percpu structure for %s\n", __func__, cpu, rtp->name);
> 179 WARN_ON_ONCE(!rtpcp);
> 180 if (cpu)
> > 181 raw_spin_lock_init(&rtpcp->lock);
> 182 raw_spin_lock_irqsave_rcu_node(rtpcp, flags);
> 183 if (rcu_segcblist_empty(&rtpcp->cblist))
> 184 rcu_segcblist_init(&rtpcp->cblist);
> 185 raw_spin_unlock_irqrestore_rcu_node(rtpcp, flags);
> 186 }
> 187 raw_spin_unlock_irqrestore(&rtp->cbs_gbl_lock, flags);
> 188
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


\
 
 \ /
  Last update: 2021-11-18 04:02    [W:0.044 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site