lkml.org 
[lkml]   [2021]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH RFT] memory: renesas-rpc-if: simplify register update
Date
Hi Wolfram,

Thank you for the patch.

> -----Original Message-----
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Sent: 17 November 2021 10:29
> To: linux-renesas-soc@vger.kernel.org
> Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; Wolfram Sang <wsa+renesas@sang-
> engineering.com>; Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>; linux-
> kernel@vger.kernel.org
> Subject: [PATCH RFT] memory: renesas-rpc-if: simplify register update
>
> No need to open code regmap_update_bits().
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Only build tested as I don't have the G2L hardware.
> @Prabhakar: would you also kindly test this patch?
>
Dumped the register setting with and without this patch. And also tested it on RZ/G2L.

Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> drivers/memory/renesas-rpc-if.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c index
> a9f3e7bdddf8..0c8f00323a91 100644
> --- a/drivers/memory/renesas-rpc-if.c
> +++ b/drivers/memory/renesas-rpc-if.c
> @@ -258,17 +258,14 @@ EXPORT_SYMBOL(rpcif_sw_init);
>
> static void rpcif_rzg2l_timing_adjust_sdr(struct rpcif *rpc) {
> - u32 data;
> -
> regmap_write(rpc->regmap, RPCIF_PHYWR, 0xa5390000);
> regmap_write(rpc->regmap, RPCIF_PHYADD, 0x80000000);
> regmap_write(rpc->regmap, RPCIF_PHYWR, 0x00008080);
> regmap_write(rpc->regmap, RPCIF_PHYADD, 0x80000022);
> regmap_write(rpc->regmap, RPCIF_PHYWR, 0x00008080);
> regmap_write(rpc->regmap, RPCIF_PHYADD, 0x80000024);
> -
> - regmap_read(rpc->regmap, RPCIF_PHYCNT, &data);
> - regmap_write(rpc->regmap, RPCIF_PHYCNT, data | RPCIF_PHYCNT_CKSEL(3));
> + regmap_update_bits(rpc->regmap, RPCIF_PHYCNT, RPCIF_PHYCNT_CKSEL(3),
> + RPCIF_PHYCNT_CKSEL(3));
> regmap_write(rpc->regmap, RPCIF_PHYWR, 0x00000030);
> regmap_write(rpc->regmap, RPCIF_PHYADD, 0x80000032); }
> --
> 2.30.2

\
 
 \ /
  Last update: 2021-11-18 03:42    [W:0.048 / U:0.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site