lkml.org 
[lkml]   [2021]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectdrivers/platform/chrome/cros_ec_typec.c:900:39: sparse: sparse: cast to restricted __le16
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 42eb8fdac2fc5d62392dcfcf0253753e821a97b0
commit: 3b3dd1f0dbfe92781c60f36ea5c22b26360f9909 platform/chrome: cros_ec_typec: Report SOP' PD revision from status
date: 10 months ago
config: x86_64-randconfig-s021-20211117 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3b3dd1f0dbfe92781c60f36ea5c22b26360f9909
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 3b3dd1f0dbfe92781c60f36ea5c22b26360f9909
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/chrome/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/platform/chrome/cros_ec_typec.c:900:39: sparse: sparse: cast to restricted __le16

vim +900 drivers/platform/chrome/cros_ec_typec.c

870
871 static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num)
872 {
873 struct ec_response_typec_status resp;
874 struct ec_params_typec_status req = {
875 .port = port_num,
876 };
877 int ret;
878
879 ret = cros_typec_ec_command(typec, 0, EC_CMD_TYPEC_STATUS, &req, sizeof(req),
880 &resp, sizeof(resp));
881 if (ret < 0) {
882 dev_warn(typec->dev, "EC_CMD_TYPEC_STATUS failed for port: %d\n", port_num);
883 return;
884 }
885
886 /* Handle any events appropriately. */
887 if (resp.events & PD_STATUS_EVENT_SOP_DISC_DONE && !typec->ports[port_num]->sop_disc_done) {
888 ret = cros_typec_handle_sop_disc(typec, port_num);
889 if (ret < 0)
890 dev_err(typec->dev, "Couldn't parse SOP Disc data, port: %d\n", port_num);
891 else
892 typec->ports[port_num]->sop_disc_done = true;
893 }
894
895 if (resp.events & PD_STATUS_EVENT_SOP_PRIME_DISC_DONE &&
896 !typec->ports[port_num]->sop_prime_disc_done) {
897 u16 sop_prime_revision;
898
899 /* Convert BCD to the format preferred by the TypeC framework */
> 900 sop_prime_revision = (le16_to_cpu(resp.sop_prime_revision) & 0xff00) >> 4;
901 ret = cros_typec_handle_sop_prime_disc(typec, port_num, sop_prime_revision);
902 if (ret < 0)
903 dev_err(typec->dev, "Couldn't parse SOP' Disc data, port: %d\n", port_num);
904 else
905 typec->ports[port_num]->sop_prime_disc_done = true;
906 }
907 }
908

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-11-18 03:11    [W:0.054 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site