lkml.org 
[lkml]   [2021]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/6] phy: qualcomm: qmp: Add missing struct documentation
    On Tue 16 Nov 04:39 CST 2021, Vinod Koul wrote:

    > dp-* members were added to qmp_phy_combo_cfg but documentation was
    > missed, so add that.
    >
    > drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_aux_cfg' not described in 'qmp_phy'
    > drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_opts' not described in 'qmp_phy'
    > drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_clks' not described in 'qmp_phy'
    >

    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

    Regards,
    Bjorn

    > Signed-off-by: Vinod Koul <vkoul@kernel.org>
    > ---
    > drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++
    > 1 file changed, 3 insertions(+)
    >
    > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
    > index 456a59d8c7d0..c96639d5f581 100644
    > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
    > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
    > @@ -2973,6 +2973,9 @@ struct qmp_phy_combo_cfg {
    > * @qmp: QMP phy to which this lane belongs
    > * @lane_rst: lane's reset controller
    > * @mode: current PHY mode
    > + * @dp_aux_cfg: Display port aux config
    > + * @dp_opts: Display port optional config
    > + * @dp_clks: Display port clocks
    > */
    > struct qmp_phy {
    > struct phy *phy;
    > --
    > 2.31.1
    >

    \
     
     \ /
      Last update: 2021-11-18 01:22    [W:5.401 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site